| *** tristan has joined #buildstream | 06:43 | |
| *** ChanServ sets mode: +o tristan | 06:43 | |
| *** tristan has quit IRC | 06:47 | |
| *** tristan has joined #buildstream | 06:47 | |
| *** ChanServ sets mode: +o tristan | 07:50 | |
| tristan | Thanks for the patch TingPing ! | 07:54 |
|---|---|---|
| * tristan realizes now that he missed something... | 07:54 | |
| tristan | We need to make -j %{max-jobs} into an env var... otherwise the number of cpus detected (or user preference override), will effect the cache key of a build | 07:55 |
| * tristan writes up a quick fix for that... | 07:56 | |
| tristan | this fixes it: https://gitlab.com/tristanvb/buildstream/commit/a2fa4368d1c417be6687969c5ddbbee68628c156 :) | 08:01 |
| paulsher3ood | tristan: pls look at how ybd does it | 08:38 |
| paulsher3ood | for cache-key, it is always either 'single' or 'parallel' | 08:39 |
| paulsher3ood | doesn't that solve your issue? | 08:39 |
| * paulsher3ood dislikes tristan's patch, because wtf does 'NINJAJOBS' mean :) | 08:40 | |
| paulsher3ood | i'm wrong, since ninja is a thing | 08:45 |
| paulsher3ood | i'll get my coat | 08:45 |
| tristan | :) | 08:51 |
| tristan | paulsher3ood, I have been considering that thing about max-jobs, of course... thing is as you say it's not the same thing to configure max-jobs and to configure 'notparallel' (which is currently not a 'thing' yet) | 08:52 |
| tristan | I think notparallel is a decent name for "this thing cant handle parallel makes" just because of make's .NOTPARALLEL feature | 08:52 |
| paulsher3ood | +1 | 08:53 |
| tristan | paulsher3ood, but indeed, there are 2 things... 1.) A way to pass the configuration of how many jobs an element can use... 2.) A way to say this thing cant be parallelized.... where only (2) should effect cache key | 08:53 |
| paulsher3ood | agreed | 08:53 |
| *** ssam2 has joined #buildstream | 10:00 | |
| *** leeming has quit IRC | 10:12 | |
| *** leeming has joined #buildstream | 10:29 | |
| * leeming prefers ninjas to do jobs than pirates | 11:21 | |
| *** kurbeco has joined #buildstream | 13:11 | |
| *** tristan has quit IRC | 13:38 | |
| *** tristan has joined #buildstream | 13:38 | |
| *** ChanServ sets mode: +o tristan | 13:38 | |
| *** tristan has quit IRC | 14:38 | |
| *** tristan has joined #buildstream | 15:07 | |
| *** ChanServ sets mode: +o tristan | 15:47 | |
| *** ssam2 has quit IRC | 18:09 | |
| *** tiagogomes has quit IRC | 18:41 | |
| *** tristan has quit IRC | 21:29 | |
| *** tristan has joined #buildstream | 22:12 | |
| *** tristan has quit IRC | 23:24 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!