*** psahoo has joined #automotive | 04:53 | |
*** leon-anavi has joined #automotive | 06:29 | |
*** leon-anavi has quit IRC | 06:33 | |
*** leon-anavi has joined #automotive | 06:33 | |
*** leon-anavi has quit IRC | 06:39 | |
*** leon-anavi has joined #automotive | 07:01 | |
*** toscalix has joined #automotive | 08:06 | |
*** toscalix has quit IRC | 08:11 | |
*** toscalix has joined #automotive | 08:14 | |
*** toscalix_ has joined #automotive | 08:46 | |
*** toscalix has quit IRC | 08:47 | |
*** toscalix_ has quit IRC | 09:48 | |
*** toscalix has joined #automotive | 10:17 | |
*** toscalix has quit IRC | 10:31 | |
*** kooltux has quit IRC | 10:35 | |
*** toscalix has joined #automotive | 10:35 | |
*** toscalix has quit IRC | 10:49 | |
*** kooltux has joined #automotive | 10:50 | |
*** kooltux has quit IRC | 10:53 | |
*** toscalix has joined #automotive | 11:02 | |
*** kooltux has joined #automotive | 11:15 | |
*** toscalix has quit IRC | 12:24 | |
*** psahoo_ has joined #automotive | 12:31 | |
*** psahoo has quit IRC | 12:35 | |
*** gkiagia has quit IRC | 13:24 | |
*** gkiagia has joined #automotive | 13:36 | |
*** psahoo_ has quit IRC | 13:42 | |
*** psahoo_ has joined #automotive | 13:56 | |
*** IanWizard has quit IRC | 13:59 | |
*** leon-anavi has quit IRC | 14:01 | |
*** leon-anavi has joined #automotive | 14:08 | |
mvlad | smurray: mind taking a look at https://gerrit.automotivelinux.org/gerrit/c/apps/agl-service-homescreen/+/26344 to see if that seems reasonable? | 15:10 |
---|---|---|
smurray | mvlad: no concerns wrt locking for client_list? | 15:12 |
*** leon-anavi has quit IRC | 15:18 | |
mvlad | smurray: there's a lock taken at line 209 | 15:19 |
smurray | mvlad: I guess there's no code paths that can result in addClient getting called that don't go through handleRequest? | 15:33 |
*** psahoo_ has quit IRC | 16:07 | |
mvlad | smurray: well, there's HS_AfmMainProxy::start() but it never had a lock. (it is called from tap_shortcut) | 16:28 |
smurray | mvlad: I suspect it's fine, then | 16:29 |
mvlad | yeah, would've nice if we could spin CI to give it a test. | 16:30 |
mvlad | but for homescreen it is problematic | 16:30 |
*** indy has quit IRC | 17:01 | |
*** toscalix has joined #automotive | 19:12 | |
*** anjumkaiser has joined #automotive | 19:40 | |
*** indy has joined #automotive | 20:10 | |
*** toscalix has quit IRC | 22:26 | |
*** anjumkaiser has quit IRC | 22:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!