*** mdurnev has joined #automotive | 02:06 | |
mranostay | dl9pf: any reason faac is failing to build now? did gcc get update? | 02:20 |
---|---|---|
*** mkelly has joined #automotive | 02:22 | |
*** thaytan has quit IRC | 02:26 | |
*** mkelly has quit IRC | 02:30 | |
*** D9 has quit IRC | 02:33 | |
*** D9 has joined #automotive | 02:38 | |
khem | mranostay: what is the error ? | 02:39 |
mranostay | main.c:718:9: error: format not a string literal and no format arguments [-Werror=format-security] | 02:39 |
mranostay | fprintf(stderr, faac_copyright_string); | 02:39 |
mranostay | recipe hasn't changed so seems like another pedantic gcc Werror | 02:40 |
mranostay | khem: also for porter if that matters | 02:44 |
*** thaytan has joined #automotive | 03:06 | |
khem | mranostay: ok so you must be enabling security flags | 03:17 |
khem | which is not default in OE-Core | 03:17 |
*** rdale_ct has quit IRC | 03:40 | |
mranostay | khem: well i'm not.. something is :) | 03:53 |
khem | its a distro thing so I believe the distro you are using is based of poky-lsb | 04:00 |
khem | but meta-openembedded is not vetted with security flags on. Thats where faac recipe comes from | 04:00 |
mranostay | khem: i get it.. just wonder who though adding security flags to distro was important atm :) | 04:02 |
mranostay | and how it even built in the CI | 04:02 |
khem | mranostay: here is fix | 04:35 |
khem | https://github.com/kraj/meta-openembedded/commit/4f105f6904132b5058ed538aed73f0b0ec3106b0 | 04:36 |
khem | have fun | 04:36 |
khem | yes its a good thing | 04:36 |
khem | I have a plan to propose this as default for oe-core | 04:37 |
mranostay | khem: thought of that.. but there are quite a few other statements that will fail in faac and libuiomux.. so far only packages blowing up | 04:38 |
mranostay | what is the security risk btw? someone accidently has a format statement in the string, and it reads random memory? | 04:39 |
khem | mranostay: if its not there then it will assume that format is part of variable string its passed as parameter which could not be trusted since it may inject things like %n | 04:45 |
khem | which is a security hole | 04:45 |
mranostay | yeah figured | 04:45 |
mranostay | kicking off a build with a horrible CFLAGS override to be sure those are the only two packages affected | 04:46 |
mranostay | at least on porter | 04:46 |
mranostay | khem: fputs() would be better since it would drop the "%s" | 04:47 |
khem | if we know string needs no formatting then yes | 04:49 |
mranostay | khem: what is __STRING? | 04:51 |
khem | its a macro that comes from sys/cdefs.h | 04:52 |
khem | in short BSD'ism | 04:53 |
khem | that glibc inhrited | 04:53 |
khem | but musl refuses | 04:53 |
mranostay | ah many "standards" | 04:54 |
khem | musl is exposing lot of non-portable code in world | 04:54 |
khem | musl sticks to POSIX for most of stuff | 04:55 |
mranostay | ah right fputs only works for stdout anyway | 04:57 |
khem | AGL should think of using musl instead of glibc | 04:58 |
khem | and also clang :) | 04:59 |
mranostay | i have no comment on that :) | 04:59 |
khem | I have kodi running on musl it takes 25M-85M less RAM at runtime on pi3 | 05:01 |
khem | when playing 1080p | 05:01 |
mranostay | ah would be helpful with the limited GPU memory | 05:01 |
mranostay | or rather shared memory | 05:02 |
khem | yes | 05:07 |
mranostay | hmm line 52 is causing a issue in libuiomux https://www.irccloud.com/pastebin/GsUiGBCR/ | 05:11 |
mranostay | likely a casting issue? | 05:11 |
mranostay | ah should be a puts | 05:11 |
khem | its trying to print a char* with out formatting string | 05:15 |
mranostay | ah yeah easy fix | 05:18 |
khem | may be you need printf("%p",name[i]); | 05:20 |
khem | or printf("%s",name[i]); | 05:21 |
khem | actually %s is right replacement | 05:24 |
mranostay | yeah | 05:34 |
*** fredw has joined #automotive | 06:55 | |
*** claneys has joined #automotive | 06:56 | |
*** fredw has quit IRC | 07:04 | |
*** fredw has joined #automotive | 07:09 | |
*** rajm has joined #automotive | 07:12 | |
*** jobol has joined #automotive | 07:18 | |
*** ctbruce has joined #automotive | 07:26 | |
*** fredw has quit IRC | 07:27 | |
*** chris_g has joined #automotive | 07:37 | |
*** leon has joined #automotive | 07:46 | |
*** leon is now known as Guest76930 | 07:46 | |
*** Guest76930 is now known as leon-anavi | 07:46 | |
leon-anavi | hi | 07:46 |
*** toscalix has joined #automotive | 07:55 | |
*** fredw has joined #automotive | 07:56 | |
*** reinar has quit IRC | 07:58 | |
*** rdale has joined #automotive | 08:11 | |
*** kbroulik has joined #automotive | 08:11 | |
*** ZenEntropy has joined #automotive | 08:21 | |
*** fredw has quit IRC | 08:25 | |
*** fredw has joined #automotive | 08:27 | |
dl9pf | mranostay: gcc security flags got acticated | 08:40 |
dl9pf | mranostay: you can add an override it in this way: https://git.automotivelinux.org/AGL/meta-agl/tree/meta-agl-distro/conf/distro/poky-agl.conf#n78 | 08:44 |
*** praneeth has quit IRC | 08:55 | |
*** praneeth has joined #automotive | 08:55 | |
CTtpollard | hey leon-anavi | 09:03 |
leon-anavi | hi CTtpollard how are you? | 09:03 |
*** claneys has quit IRC | 09:06 | |
*** claneys has joined #automotive | 09:06 | |
*** claneys has quit IRC | 09:09 | |
*** claneys has joined #automotive | 09:09 | |
CTtpollard | leon-anavi: I'm well, yourself? :) | 09:38 |
leon-anavi | tired, too much work recently but otherwise ok :) | 09:42 |
*** fredw has quit IRC | 09:54 | |
CTtpollard | leon-anavi: I know that feeling | 10:33 |
*** ZenEntropy has quit IRC | 10:37 | |
*** lordPoseidon has quit IRC | 10:38 | |
*** ZenEntropy has joined #automotive | 10:49 | |
leon-anavi | :) | 10:50 |
*** fredw has joined #automotive | 11:00 | |
*** lordPoseidon has joined #automotive | 11:19 | |
*** ZenEntropy has quit IRC | 11:26 | |
dl9pf | jbocklage: an idea from the top of your head for https://jira.automotivelinux.org/browse/SPEC-508 ?? | 11:27 |
jbocklage | dl9pf: i'll check | 11:29 |
dl9pf | jbocklage: tnx | 11:45 |
*** caiortp has joined #automotive | 11:58 | |
*** ZenEntropy has joined #automotive | 12:00 | |
*** wesam has joined #automotive | 12:28 | |
*** toscalix has quit IRC | 12:42 | |
*** Cerza has joined #automotive | 13:22 | |
*** Cerza has quit IRC | 13:26 | |
*** Cerza has joined #automotive | 13:27 | |
*** Cerza has quit IRC | 13:29 | |
*** Cerza has joined #automotive | 13:29 | |
*** toscalix has joined #automotive | 13:38 | |
*** ZenEntropy has quit IRC | 13:40 | |
*** gunnarx has quit IRC | 13:49 | |
*** damyan^ has quit IRC | 13:57 | |
*** mdurnev has quit IRC | 13:59 | |
*** damyan^ has joined #automotive | 14:01 | |
*** dunderroffe_ has joined #automotive | 14:05 | |
*** dunderroffe has quit IRC | 14:07 | |
*** Cerza has quit IRC | 14:22 | |
*** gunnarx has joined #automotive | 14:24 | |
*** mpaolino has joined #automotive | 14:47 | |
*** jlrmagnus has joined #automotive | 14:57 | |
*** mkelly has joined #automotive | 14:58 | |
*** claneys has quit IRC | 15:02 | |
*** claneys has joined #automotive | 15:03 | |
*** voyager_ has quit IRC | 15:13 | |
*** kyle612_ has left #automotive | 15:18 | |
*** mkelly has quit IRC | 15:24 | |
*** jlrmagnus has quit IRC | 15:30 | |
*** wesam has quit IRC | 15:31 | |
*** toscalix has quit IRC | 15:44 | |
*** wesam has joined #automotive | 15:45 | |
*** fredw has quit IRC | 15:46 | |
*** rajm has quit IRC | 15:48 | |
*** wesam has quit IRC | 15:51 | |
*** Cerza has joined #automotive | 16:01 | |
*** Cerza has quit IRC | 16:03 | |
*** Cerza has joined #automotive | 16:03 | |
*** Cerza has quit IRC | 16:04 | |
*** Cerza has joined #automotive | 16:04 | |
*** jlrmagnus has joined #automotive | 16:10 | |
*** chris_g has quit IRC | 16:11 | |
*** Nikhil_D has quit IRC | 16:17 | |
*** Nikhil_D has joined #automotive | 16:17 | |
*** ctbruce has quit IRC | 16:18 | |
*** mpaolino has quit IRC | 16:21 | |
*** toscalix has joined #automotive | 16:23 | |
*** wesam has joined #automotive | 16:34 | |
*** leon-anavi has quit IRC | 16:36 | |
*** dunderroffe_ has quit IRC | 16:38 | |
*** zeenix has joined #automotive | 16:40 | |
*** gunnarx has quit IRC | 16:44 | |
*** kbroulik has quit IRC | 16:48 | |
*** jobol has quit IRC | 16:55 | |
*** toscalix has quit IRC | 17:12 | |
*** jlrmagnus has quit IRC | 17:23 | |
*** jlrmagnus has joined #automotive | 17:35 | |
*** claneys has quit IRC | 17:50 | |
*** jlrmagnus has quit IRC | 18:04 | |
*** voyager_ has joined #automotive | 18:08 | |
*** jlrmagnus has joined #automotive | 18:20 | |
*** voyager_ has quit IRC | 18:30 | |
*** jlrmagnus_ has joined #automotive | 18:39 | |
*** jlrmagnus has quit IRC | 18:41 | |
*** voyager_ has joined #automotive | 18:47 | |
*** wesam has quit IRC | 20:01 | |
*** voyager_ has quit IRC | 20:55 | |
*** voyager_ has joined #automotive | 20:55 | |
*** jlrmagnus_ has quit IRC | 21:07 | |
*** jlrmagnus has joined #automotive | 21:15 | |
*** Cerza has quit IRC | 21:45 | |
*** gunnarx has joined #automotive | 21:55 | |
*** gunnarx has joined #automotive | 21:55 | |
*** caiortp has quit IRC | 22:04 | |
*** jlrmagnus has quit IRC | 22:16 | |
*** jlrmagnus has joined #automotive | 22:31 | |
*** joone has quit IRC | 22:49 | |
*** jlrmagnus has quit IRC | 22:58 | |
*** joone has joined #automotive | 23:02 | |
*** Cerza has joined #automotive | 23:07 | |
*** jlrmagnus has joined #automotive | 23:15 | |
*** gunnarx has quit IRC | 23:17 | |
*** murphy has quit IRC | 23:35 | |
*** rayjenkins has joined #automotive | 23:42 | |
*** rayjenkins has quit IRC | 23:44 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!