*** mdurnev has joined #automotive | 01:19 | |
*** AlisonChaiken has quit IRC | 03:02 | |
*** khem has quit IRC | 04:22 | |
*** Tartarus has quit IRC | 04:27 | |
*** khem has joined #automotive | 04:27 | |
*** Tartarus has joined #automotive | 04:28 | |
*** AlisonChaiken has joined #automotive | 05:32 | |
*** dirkb has joined #automotive | 06:11 | |
*** vivekg has joined #automotive | 06:32 | |
*** praneeth has quit IRC | 06:43 | |
*** praneeth has joined #automotive | 06:43 | |
*** jlrmagnus has joined #automotive | 08:05 | |
*** jobol has joined #automotive | 08:12 | |
*** rdale has joined #automotive | 08:32 | |
*** vivekg has quit IRC | 08:34 | |
*** ctbruce has joined #automotive | 08:37 | |
*** jlrmagnus has quit IRC | 08:57 | |
*** toscalix has joined #automotive | 08:59 | |
*** leon-anavi has joined #automotive | 09:04 | |
leon-anavi | hi | 09:06 |
---|---|---|
jobol | hi leon-anavi | 09:11 |
leon-anavi | hi jobol how are you? | 09:16 |
jobol | I'm okay and you? | 09:17 |
* jobol asks itself why ldconfig fails? | 09:18 | |
*** jlrmagnus has joined #automotive | 09:32 | |
*** zeenix has joined #automotive | 09:46 | |
zeenix | hi | 09:52 |
zeenix | leon-anavi: the build was fine for minnowboard | 09:52 |
zeenix | leon-anavi: i assume you tested it already? I'm wondering if i need to SOTA | 09:53 |
zeenix | s/SOTA/test SOTA/ | 09:53 |
leon-anavi | hi zeenix, yes, I tested the build for rpi3 before submitting the changes to GitHub | 09:57 |
*** toscalix has quit IRC | 09:58 | |
jbocklage | morning | 10:05 |
zeenix | leon-anavi: great | 10:10 |
CTtpollard | I think master GDP is broke | 10:19 |
leon-anavi | hm... | 10:20 |
leon-anavi | zeenix, I received an email that you have merged my change that updates meta-rust | 10:21 |
leon-anavi | but what about the other patches? | 10:21 |
leon-anavi | meta-rust goes together with them, otherwise they will not work | 10:21 |
CTtpollard | yeh it needs to include the update to meta-genivi-dev | 10:21 |
leon-anavi | RVI SOTA client Yocto/OE recipe highly depends on meta-rust. The old version of the recipe does NOT work with the new version of the meta-rust. The new version of the recipe does NOT work with the old version of meta-rust. New version of RVI SOTA Client goes only with the new version of meta-rust. | 10:23 |
CTtpollard | Yes, it's safe to merge to master meta-genivi-dev first because GDP brings in hard refs, not master of it | 10:24 |
zeenix | leon-anavi: yeah i was reviewing them, i realized commit logs are still not perfect yet :) | 10:25 |
CTtpollard | I would push a revert of the commit in the meantime | 10:26 |
zeenix | leon-anavi: btw, my nitpicks are nothing personal. I'm known to be very pedantic about commit logs | 10:26 |
zeenix | CTtpollard: why, build was broken anyway | 10:26 |
CTtpollard | It just sets a president for the wrong merge order, imo | 10:27 |
leon-anavi | zeenix, could you please let me know what remarks do you have about the other commit messages? | 10:27 |
zeenix | leon-anavi: i commented on the PR | 10:29 |
zeenix | CTtpollard: i think this is the correct order: Update the lower layer first and then update the higher layer that depends on it.. | 10:30 |
CTtpollard | meta-genivi-dev is the lower layer | 10:31 |
CTtpollard | Anyway, it just means there will always be 1 commit that is broken in the parallel PR scenario | 10:31 |
zeenix | SOTA depends on Rust, so Rust should be updated first | 10:31 |
zeenix | or that's the logic i used | 10:32 |
CTtpollard | GDP depends on meta-genivi-dev though beyond that | 10:32 |
*** ppeter has joined #automotive | 10:32 | |
zeenix | CTtpollard: but i wouldn't have merged if I had realized i'll have issues with commit logs of the other PR | 10:32 |
CTtpollard | if GDP was to always bring in meta-genivi-dev HEAD, then the reverse would be more feasible | 10:33 |
leon-anavi | ugh | 10:33 |
*** ppeter has quit IRC | 10:33 | |
leon-anavi | zeenix, next time if you have remark please write them down before merging the patches. | 10:33 |
leon-anavi | I will try to address your remarks regarding the commit messages asap but right now since just half of the things are merged we have a broken GDP master :( | 10:34 |
zeenix | we already had a broken gdp master :) | 10:34 |
zeenix | it's just broken for a different reason now | 10:34 |
zeenix | leon-anavi: but yes, next time i'll try to handle it better | 10:35 |
leon-anavi | zeenix, regarding your comment: "it says who needs the change but no information on change itself or why SOTA needs it exactly" could you please provide me an example git message that describes the case? | 10:37 |
leon-anavi | It will be easier for me to fulfill your requirements if there is an example. Sorry but I am confused right now. | 10:37 |
zeenix | leon-anavi: sure thing | 10:38 |
leon-anavi | thanks in advance | 10:39 |
zeenix | leon-anavi: it's not easy to find specific examples of course but i can point you to what i consider good commit logs | 10:40 |
zeenix | https://git.gnome.org/browse/gnome-boxes/commit/?id=f147894623c5509d1f586c22859e90aa5dd6085c | 10:40 |
leon-anavi | ok, I just want to make sure that next time all commit message will match your requirements and the patch will be merged. | 10:40 |
zeenix | https://git.gnome.org/browse/gnome-boxes/commit/?id=d084a9e6e6c896a38d9f1e44865052d3dcc52e99 | 10:40 |
zeenix | leon-anavi: https://wiki.gnome.org/Git/CommitMessages/ | 10:41 |
rZr | <zeenix> we already had a broken gdp master :) | 10:41 |
zeenix | leon-anavi: most of these are standard git log rules that are followed across many projects | 10:41 |
rZr | rvi sota package ? | 10:41 |
zeenix | yes | 10:41 |
rZr | I faced this too | 10:42 |
zeenix | rZr: yes, it's now broken in another way but it's the first step towards fixing it :) | 10:42 |
rZr | zeenix, any ETA ? | 10:42 |
zeenix | rZr: 1h? :) | 10:42 |
rZr | ok cool ask me when you want me to check | 10:43 |
rZr | I wanted to prepare iotivity nodejs image | 10:43 |
zeenix | rZr: well if you need to test, you can already grab leon-anavi's PR and start the build | 10:44 |
zeenix | rZr: https://github.com/GENIVI/meta-genivi-dev/pull/48 | 10:44 |
rZr | THX leon-anavi | 10:44 |
leon-anavi | zeenix, for example is this OK for you as a description? | 10:48 |
leon-anavi | libgit2: Add libgit2 | 10:48 |
leon-anavi | The latest version of RVI SOTA Client depends on | 10:48 |
leon-anavi | the Git linkable library and the SOTA client | 10:48 |
leon-anavi | cannot be build without libgit2 | 10:48 |
leon-anavi | [GDP-517] rvi-sota-client-git-r0 compiling failed | 10:48 |
zeenix | leon-anavi: yes, but no need for "libgit2:" prefix here and if you want it, just go with soemthing like "libgit2: Add to recipes" | 10:49 |
zeenix | leon-anavi: but please, don't see them as "my requirements" | 10:50 |
rZr | prefixes are good | 10:51 |
zeenix | rZr: yes but in this case, it's not adding anything | 10:51 |
rZr | I will not nitpick on this | 10:51 |
leon-anavi | zeenix, if you want merge my patches because of the commit message then it is a requirement :) | 10:52 |
zeenix | leon-anavi: yes, stress on "my" part | 10:52 |
zeenix | try sending a patch to kernel list :) | 10:52 |
leon-anavi | I prefer to have a prefix such as: libgit2: Is "libgit2: Add to recipes" OK? | 10:52 |
zeenix | leon-anavi: sure, that's why i gave you two choices :) | 10:53 |
rZr | I'd vote for choice #2 too | 10:53 |
leon-anavi | zeenix, I am stressing on "your" part because your requirements are a little bit different from the requirement of the previous maintainers therefore I am not used to them | 10:55 |
leon-anavi | zeenix, could you please write them down somewhere in the wiki? This way it will be easier for new contributors? | 10:55 |
zeenix | leon-anavi: yes i was about to ask where would be the best place | 10:56 |
zeenix | leon-anavi: where are the requirements of previous maintainers documented? | 10:58 |
zeenix | do we have a wikipage for this then already? | 10:58 |
*** rdale has quit IRC | 11:01 | |
*** rdale has joined #automotive | 11:06 | |
*** fredw has joined #automotive | 11:08 | |
*** fredw has quit IRC | 11:53 | |
*** caiortp has joined #automotive | 11:53 | |
*** claneys has joined #automotive | 12:23 | |
*** jlrmagnus has quit IRC | 12:24 | |
CTtpollard | So gdp.git just needs updating to the head of mgd.git now to be fixed? | 12:30 |
zeenix | mgd ? | 12:31 |
zeenix | CTtpollard: i just merged the 2nd PR so it should be good? | 12:32 |
CTtpollard | meta-genivi-dev | 12:32 |
CTtpollard | gdp need to be updated to bring in a ref of meta-genivi-dev that has that merge | 12:32 |
CTtpollard | i.e, HEAD now | 12:32 |
CTtpollard | unless you wanted the submodule to track head, but I'd warn against that | 12:33 |
zeenix | ah yes, i'm pushing that now | 12:36 |
zeenix | CTtpollard: done | 12:41 |
CTtpollard | I love how github can show submodule diffs if also hosted on github now | 12:41 |
CTtpollard | instead of just a sha change in .gitmodules | 12:42 |
CTtpollard | https://github.com/GENIVI/genivi-dev-platform/commit/5a78130f1fdea789911115e09fd55c6d737c2316 | 12:43 |
dl9pf | jbocklage: https://gerrit.automotivelinux.org/gerrit/#/c/7571/1 | 12:44 |
dl9pf | jbocklage: https://gerrit.automotivelinux.org/gerrit/#/c/7569/ | 12:45 |
jbocklage | I see | 12:45 |
dl9pf | cool, tnx | 12:45 |
*** fredw has joined #automotive | 12:48 | |
*** mdurnev has quit IRC | 12:51 | |
*** dirkb has quit IRC | 12:54 | |
*** fredw has quit IRC | 12:57 | |
*** fredw has joined #automotive | 12:57 | |
fury | hi guys | 13:06 |
fury | how's it hangin? | 13:06 |
zeenix | leon-anavi: would it be possible for you to prep a very brief report on changes brought from these updates, in tomorrow's meeting? | 13:36 |
leon-anavi | yes | 13:36 |
zeenix | leon-anavi: awesome, thanks! | 13:36 |
leon-anavi | could you please include a topic to meeting to discuss the guidelines for git commit messages and where to describe it? | 13:37 |
leon-anavi | I think it will be really convenient to have a document in the wiki or somewhere else with these guidelines. | 13:37 |
zeenix | leon-anavi: i was about to start a wikipage | 13:37 |
leon-anavi | ok, even better :) | 13:38 |
zeenix | leon-anavi: but if i forget, please do remind me in the meeting | 13:38 |
leon-anavi | ok | 13:38 |
zeenix | gah, wiki hangs chrome here when I click the "location" link in the page creation UI of wiki here | 13:43 |
zeenix | or is it just incredibly slow? | 13:44 |
CTtpollard | It's confluence so don't expect it to be fast :) | 13:47 |
CTtpollard | there's a policies section under GENIVI Development Platform management | 13:49 |
zeenix | CTtpollard: i'm not but i waited for minutes | 13:52 |
zeenix | https://at.projects.genivi.org/wiki/display/PROJ/How+to+contribute+to+GENIVI | 13:52 |
zeenix | this seems like the perfect place | 13:52 |
CTtpollard | Note that's Genivi policy | 13:53 |
CTtpollard | not just GDP | 13:53 |
zeenix | hmm.. we accept patches from list as well? | 13:53 |
CTtpollard | So I expect changes there have to go through review, if not jeremiah first | 13:53 |
zeenix | i think there should be just one way officially and then accept the patches from list if they come there, but no strong opinion on this | 13:54 |
CTtpollard | Yes, some Genivi members can't use github t&c, apparently | 13:54 |
zeenix | ah ok | 13:54 |
CTtpollard | I think BMW had a problem with this initially, as some of their repos (Audiomanager for example) took a while to transition canoncial upstreams | 13:55 |
CTtpollard | Also like I say the contribute page is for Genivi in general, I agree PR > ML for GDP patches | 13:56 |
CTtpollard | other projects may vary | 13:56 |
CTtpollard | GDP took a rough policy of conforming with general yocto practices for commit style | 13:57 |
CTtpollard | Is github still banned in China? | 13:58 |
zeenix | CTtpollard: jeremiah says "just edit" :) | 14:06 |
leon-anavi | zeenix, if you are unsure about editing the rules why don't you share your planned changes in the mailing list for a discussion? | 14:22 |
leon-anavi | this way more people will get involved and in the same time will be better prepared for the changes. | 14:23 |
zeenix | leon-anavi: i'm not unsure, just needed to check with jeremiah if it's ok | 14:23 |
leon-anavi | ok | 14:24 |
*** ohmy has joined #automotive | 14:52 | |
ohmy | hello | 14:52 |
ohmy | i'm using gdp 11rc2 qemu image, i'd like to know how to launch one of the applications in the launcher, i can cycle between them using left right keyboard keys but nothing looks to be used to launch the diffeerent aaps | 14:54 |
ohmy | any insight please ? | 14:54 |
ohmy | https://at.projects.genivi.org/wiki/display/GDP/QEMU+x86_64+Hardware+Setup+and+Software+Installation please, any one know how to control this HMI ? | 14:59 |
CTtpollard | touch the icon | 15:01 |
CTtpollard | or click, etc | 15:02 |
ohmy | it's qemu image | 15:02 |
CTtpollard | click then :) | 15:02 |
ohmy | CTtpollard: tried, there's no mouse cursor .. tried every single obious thing :) | 15:03 |
ohmy | CTtpollard: is there anyway to ionteract with the launcher using dbus for example ? | 15:04 |
ohmy | have a nice day | 15:12 |
*** ohmy has quit IRC | 15:12 | |
*** kbroulik has quit IRC | 15:15 | |
rZr | zeenix, leon-anavi, gdb fixed | 15:57 |
leon-anavi | rZr, thanks for testing it | 16:06 |
rZr | yw | 16:06 |
*** jlrmagnus has joined #automotive | 16:10 | |
*** jlrmagnus has quit IRC | 16:20 | |
*** jlrmagnus has joined #automotive | 16:35 | |
*** jeremiah has quit IRC | 16:49 | |
*** jeremiah has joined #automotive | 16:50 | |
*** ctbruce has quit IRC | 16:51 | |
*** jlrmagnus has quit IRC | 16:52 | |
*** zeenix has quit IRC | 17:19 | |
*** AlisonChaiken has quit IRC | 17:23 | |
*** fredw has quit IRC | 17:41 | |
*** leon-anavi has quit IRC | 18:09 | |
*** rdale has quit IRC | 18:10 | |
*** AlisonChaiken has joined #automotive | 18:19 | |
*** caiortp has quit IRC | 18:41 | |
*** jobol has quit IRC | 19:35 | |
*** fredw has joined #automotive | 19:35 | |
*** fredw has quit IRC | 20:29 | |
*** waltminer has joined #automotive | 20:42 | |
*** waltminer has quit IRC | 22:04 | |
*** waltminer has joined #automotive | 22:23 | |
*** robal has joined #automotive | 22:57 | |
*** waltminer has quit IRC | 23:01 | |
*** claneys has quit IRC | 23:17 | |
*** robal has quit IRC | 23:30 | |
*** waltminer has joined #automotive | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!