IRC logs for #baserock for Monday, 2017-03-27

*** gtristan has quit IRC05:15
*** ctbruce has joined #baserock07:40
*** toscalix has joined #baserock07:54
*** toscalix has quit IRC08:06
*** toscalix has joined #baserock08:07
*** toscalix has quit IRC08:09
*** toscalix has joined #baserock08:12
*** paulwaters_ has joined #baserock08:13
*** toscalix has quit IRC08:16
*** jonathanmaw has joined #baserock08:19
*** toscalix has joined #baserock08:20
*** toscalix has quit IRC08:22
*** toscalix has joined #baserock08:42
*** toscalix has quit IRC08:52
*** tiagogomes has quit IRC08:52
*** tiagogomes has joined #baserock08:54
jonathanmawjjardon, paulsherwood: can either of you review https://gitlab.com/baserock/ybd/merge_requests/329 ?08:58
*** CTtpollard has joined #baserock09:05
paulsherwoodjonathanmaw: done09:09
jonathanmawpaulsherwood: I don't suppose you can give some insight into why we use run_sandbox_with_redirection()?09:11
paulsherwoodlet me see if i can remember09:11
jonathanmawit looks like ssam was responsible for it originally (commit 66cf5ba0b20ec4f6e3c1d99e1b420b455203cef7)09:12
paulsherwoodjonathanmaw: almost certainly ssam2 will know better...09:12
*** ssam2 has joined #baserock09:13
*** ChanServ sets mode: +v ssam209:13
paulsherwoodjonathanmaw: is your question 'why don't we just run run_sandbox' ?09:14
*** toscalix has joined #baserock09:14
jonathanmawpaulsherwood: yep, why not run_sandboxed09:15
jonathanmawssam2: you implemented that code originally. Can you remember the decision behind using run_sandbox_with_redirection()?09:15
ssam2hmm09:16
ssam2you mean the name or the functionality ?09:16
jonathanmawssam2: the functionality09:16
ssam2I think so that logs are "live"09:16
jonathanmawssam2: what does that mean?09:17
ssam2it's annoying when the command inside the sandbox gives no output for hours, then at the end of the build dumps the whole log to dis09:17
ssam2*disk09:17
ssam2it's better when the log is written "as it happens"09:17
ssam2so it may have been to solve that problem09:17
jonathanmawssam2: I'm not sure how that works. looking at the code (sandboxlib/sandboxlib/chroot.py), run_sandbox_with_redirection just calls run_sandbox and discards out and err09:18
ssam2that's because out and err are written to a file09:19
ssam2it expects you to pass in file handles for stdout and stderr09:19
jonathanmawstdout and stderr passed in as arguments to run_sandbox09:19
ssam2yeah09:20
ssam2it seems pretty pointless, looking back at the code now09:20
jonathanmawok, so that's some confidence that this change isn't breaking things in strange ways, then09:20
ssam2I guess the idea of having a function with a different name was to make it clear when a call to run_command() wouldn't return stdout or stderr09:20
ssam2it's up to the user of the library to keep it that way09:21
ssam2if that's the case I never documented it in __init__.py, but that's not impossible09:21
ssam2but yeah, it was all about whether stdout & stderr are written to a pipe in memory, or written to disk09:22
ssam2and ideally it would support doing *both*, like Morph did, but I never got time to implement that09:22
ssam2I think morph did it just by modifying the commandline though, which wasn't reusable09:22
*** toscalix has quit IRC09:35
*** locallycompact has joined #baserock09:57
*** toscalix has joined #baserock10:41
*** toscalix_ has joined #baserock12:58
*** toscalix has quit IRC13:00
*** toscalix_ has quit IRC14:10
*** paulwaters_ has joined #baserock15:02
*** edcragg has joined #baserock15:41
*** ctbruce has quit IRC16:16
jjardonpaulsherwood: seems ybd managed to build systems/armv7lhf-cross-toolchain-system-x86_64.morph?  https://gitlab.com/baserock/definitions/builds/1306277316:16
*** jude_ has quit IRC16:17
paulsherwoodthat's a good thing, isn't it? :)16:17
*** jude_ has joined #baserock16:43
*** jonathanmaw has quit IRC17:16
*** locallycompact has quit IRC17:39
*** ssam2 has quit IRC18:07
*** jude_ has quit IRC18:13
*** lchlan has quit IRC19:28
*** lchlan has joined #baserock19:29
*** locallycompact has joined #baserock19:51
*** jude_ has joined #baserock20:47
*** locallycompact has quit IRC21:10
*** jude_ has quit IRC21:41
*** locallycompact has joined #baserock22:02
*** locallycompact has quit IRC22:09

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!