*** rdale has quit IRC | 03:17 | |
*** jude_ has joined #baserock | 08:11 | |
*** gtristan has quit IRC | 08:21 | |
*** gtristan has joined #baserock | 08:32 | |
*** toscalix has joined #baserock | 08:33 | |
*** cosm has quit IRC | 08:36 | |
*** noisecell has joined #baserock | 08:48 | |
*** paulwaters_ has joined #baserock | 08:58 | |
*** rdale has joined #baserock | 09:06 | |
*** rdale has quit IRC | 09:14 | |
*** rdale has joined #baserock | 09:16 | |
*** jonathanmaw has joined #baserock | 09:20 | |
*** thrace has quit IRC | 09:23 | |
*** thrace has joined #baserock | 09:24 | |
*** rdale has quit IRC | 09:38 | |
*** rdale has joined #baserock | 09:39 | |
*** ctbruce has joined #baserock | 10:56 | |
*** toscalix has quit IRC | 12:39 | |
*** toscalix has joined #baserock | 12:40 | |
*** gtristan has quit IRC | 13:37 | |
*** gtristan has joined #baserock | 14:11 | |
paulsher1ood | https://gitlab.com/baserock/ybd/merge_requests/323 | 14:59 |
---|---|---|
paulsher1ood | it's no longer WIP, i believe it works | 14:59 |
rjek | Is gitlab down? | 15:00 |
paulsher1ood | not for me | 15:00 |
paulsher1ood | also in other news https://wiki.gnome.org/Projects/BuildStream/Roadmap/ | 15:00 |
rjek | oh it just woke up | 15:01 |
*** tiagogomes has quit IRC | 15:35 | |
*** tiagogomes has joined #baserock | 15:36 | |
* jjardon reads | 15:39 | |
rjek | https://gitlab.com/baserock/ybd/commit/9351867ed30370060380c4bb1ef6c59fe4f2ccec#6b62905b9aafce15e2b8dbbb906882cc418687c9_331_331 | 16:06 |
rjek | I do not like this function :) | 16:06 |
rjek | Issues I see with it: authentication data seems global, you can't control it on a per-url basis, it manually constructs URLs and doesn't check if it needs to encode username or password, logs the credentials, calls out to wget rather than using an internal library that would allow you to hash as you download thus avoiding rereading what might a very large file twice | 16:08 |
paulsher1ood | rjek: while your criticisms are valid, i don't have time to read up on solutions for all of them... if you have any, please comment on the patch | 16:11 |
paulsher1ood | i guess i can go for auth_username and do (hidden) on that, same as passwords | 16:14 |
*** cosm has joined #baserock | 16:16 | |
*** noisecell has quit IRC | 16:25 | |
*** noisecell has joined #baserock | 16:26 | |
*** franred has joined #baserock | 16:30 | |
*** noisecell has quit IRC | 16:30 | |
*** jude_ has quit IRC | 16:39 | |
*** jonathanmaw has quit IRC | 17:28 | |
*** jude_ has joined #baserock | 17:34 | |
*** ctbruce has quit IRC | 17:40 | |
*** franred has quit IRC | 17:46 | |
*** paulwaters_ has joined #baserock | 18:04 | |
*** toscalix has quit IRC | 18:15 | |
*** jude_ has quit IRC | 18:28 | |
paulsher1ood | rjek: https://gitlab.com/baserock/ybd/merge_requests/324/diffs | 18:35 |
paulsher1ood | i don't know how to avoid using wget, and i'm now *assuming* wget knows if it needs to encode username and password | 18:36 |
paulsher1ood | (since wget creates the url) | 18:36 |
*** tiagogomes has quit IRC | 19:12 | |
*** tiagogomes has joined #baserock | 19:18 | |
*** gtristan has quit IRC | 20:02 | |
*** gary_perkins has quit IRC | 20:16 | |
*** anahuelamo has quit IRC | 20:16 | |
*** gary_perkins has joined #baserock | 20:26 | |
*** anahuelamo has joined #baserock | 20:27 | |
*** paulwaters_ has joined #baserock | 21:54 | |
*** paulwaters_ has quit IRC | 21:55 | |
ironfoot | It should be possible to fetch things using python, without wget | 22:18 |
ironfoot | Yep, using requests library | 22:21 |
rjek | Same code used for accessing kbas should do the trick | 22:25 |
rjek | Actually using that would solve almost all my issues. Reading from the request object in chunks, throwing through a statefull md5 and sha before writing to disc. | 22:26 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!