IRC logs for #baserock for Monday, 2016-09-26

*** gtristan has quit IRC05:02
*** jjardon_ has joined #baserock05:14
*** paulsher1ood has joined #baserock05:16
*** perryl has joined #baserock05:16
*** benbrown2 has joined #baserock05:16
*** vgrade_ has joined #baserock05:17
*** cyndis has quit IRC05:20
*** benbrown_ has quit IRC05:21
*** jjardon has quit IRC05:21
*** perryl_ has quit IRC05:21
*** vgrade has quit IRC05:21
*** paulsherwood has quit IRC05:21
*** cyndis has joined #baserock05:28
*** jjardon_ is now known as jjardon05:29
*** gtristan has joined #baserock05:32
*** ctbruce has joined #baserock07:31
*** ctbruce has quit IRC07:32
*** ctbruce has joined #baserock07:32
*** fay has joined #baserock07:34
*** fay is now known as Guest3812307:35
*** Guest38123 is now known as faybrocklebank07:35
*** paulwaters_ has joined #baserock07:37
*** paulwaters_ has joined #baserock07:40
*** paulwaters_ has joined #baserock07:41
*** paulwaters_ has joined #baserock07:51
*** paulwaters_ has joined #baserock07:53
*** toscalix has joined #baserock07:55
*** paulwaters_ has joined #baserock07:58
*** CTtpollard has joined #baserock08:13
*** ctbruce has quit IRC08:32
*** ctbruce has joined #baserock08:32
*** anahuelamo has joined #baserock08:32
*** ctbruce has quit IRC08:48
*** ctbruce has joined #baserock08:49
*** rdale has joined #baserock08:50
*** franred_ has quit IRC09:00
*** franred has joined #baserock09:04
*** ctbruce has joined #baserock09:12
*** ctbruce has quit IRC09:54
*** ctbruce has joined #baserock09:54
*** andrewleeming__ is now known as leeming09:56
*** locallycompact has joined #baserock10:28
*** gtristan has quit IRC10:51
*** paulwaters_ has joined #baserock11:01
pedroalvarez_Updated Changes:11:14
pedroalvarez_  https://gerrit.baserock.org/2304 Upgrade to OpenSSL 1.0.2j11:14
*** gtristan has joined #baserock11:26
*** gtristan has quit IRC11:26
*** gtristan has joined #baserock11:26
*** pedroalvarez_ is now known as pedroalvarez11:46
*** ctbruce has quit IRC11:51
*** gtristan has quit IRC12:47
*** tiagogomes_ is now known as tiagogomes13:17
*** ctbruce has joined #baserock13:39
cphangpedroalvarez: Hi! encountered an issue with the baserock-import function which wasn't working as it was using deprecated functions clone_into and unset_defaults (on MorphologyLoader). Restoring clone_into functions and removing the unset_defaults line gave a successful import of the test sinatra gem.14:16
pedroalvarezcphang: aha, do you need any further help?14:16
pedroalvarezare you going to send patches to fix that?14:16
cphangGot patches ready to go, shall I go ahead to put it on gerrit?14:17
pedroalvarezplease14:17
cphangThe only issue was whether this was a failure in my modified code, or if there's a problem with the check functio? http://paste.baserock.org/cidetirawa14:20
pedroalvarezthat error means that the line "/src/morph/morphlib/gitdir.py   488" is not being tested14:23
cphangAhh okay l488 is the clone_into func from git.py, is that because the test for that's been removed?14:32
*** toscalix_ has joined #baserock14:32
pedroalvarezcphang: hm... not sure, I believe your changes introduced the failure in the tests (given that they work for me in master)14:33
pedroalvarezbut without seeing the changes, i can't tell :/14:33
*** toscalix has quit IRC14:33
*** toscalix has joined #baserock14:49
*** toscalix_ has quit IRC14:54
cphangApologies I'm having problems getting my branch pushed14:56
cphangMade a new branch from a clone with the commit-msg hook14:56
cphangSet the remote url to ssh://<username>@gerrit.baserock.org:29418/baserock/baserock/morph.git'14:57
pedroalvarezyou could try doing `git review -R`14:58
pedroalvarezI don't think you can push a branch there, just send patches to review14:58
pedroalvarezif you want to publish the branch somewhere you need to create your own fork15:00
locallycompactdefslib calculating cache keys for assemblages, I think https://gitlab.com/baserock/defslib/blob/master/defslib/__init__.py15:11
rjekshiny15:12
cphangpedroalvarez: Many apologies. Changes should be there15:12
cphanghttps://gerrit.baserock.org/#/c/2305/15:13
*** gtristan has joined #baserock15:20
pedroalvarezcphang: right, it looks like we were not covering that function before15:38
pedroalvarezso I suggest you to do the same15:38
pedroalvarezadd "# pragma: no cover" next to "clone_into" declaration in gitdir15:38
pedroalvarezalso, please remove that ".coverage" file15:39
pedroalvarezAnd the commit message needs a bit of improving15:39
*** ctbruce has quit IRC15:41
cphangOkay will do, should I submit another patch, or can I do it within the current change-id?15:42
pedroalvarezcphang: within the current change-id please, history of the change will be kept15:45
pedroalvarezI probably should have reviewed it in gerrit, but failed to do so :)15:46
cphangpedroalvarez: okay, thanks :)15:46
pedroalvarezthanks for sending the patch :)15:47
locallycompactpaulsher1ood, what is assembly.claim doing?16:00
*** anahuelamo_ has joined #baserock16:02
*** anahuelamo has quit IRC16:02
cphangpedroalvarez: I've updated the patch. I also need to push a patch to import to remove a deprecated unset command too.16:32
pedroalvarezcphang: I've simplified the commit message16:36
pedroalvarezYou probably should have a read about good practices in commit messages. First line should be short (less than 80 chars -ish) , and have an empty line after that.16:38
cphangYeah you're right. Appreciate the heads-up :)16:39
pedroalvarezno worries :)16:40
pedroalvarezcommit looks good, I'd like to see the changes to the import tool before merging this one16:41
cphangpedroalvarez: Of course, https://gerrit.baserock.org/#/c/2306/16:48
*** faybrocklebank has quit IRC16:53
*** locallycompact has quit IRC17:28
*** tiagogomes has quit IRC17:42
*** toscalix has quit IRC18:23
*** gtristan has quit IRC18:38
*** rdale has quit IRC18:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!