| *** gtristan has quit IRC | 05:02 | |
| *** jjardon_ has joined #baserock | 05:14 | |
| *** paulsher1ood has joined #baserock | 05:16 | |
| *** perryl has joined #baserock | 05:16 | |
| *** benbrown2 has joined #baserock | 05:16 | |
| *** vgrade_ has joined #baserock | 05:17 | |
| *** cyndis has quit IRC | 05:20 | |
| *** benbrown_ has quit IRC | 05:21 | |
| *** jjardon has quit IRC | 05:21 | |
| *** perryl_ has quit IRC | 05:21 | |
| *** vgrade has quit IRC | 05:21 | |
| *** paulsherwood has quit IRC | 05:21 | |
| *** cyndis has joined #baserock | 05:28 | |
| *** jjardon_ is now known as jjardon | 05:29 | |
| *** gtristan has joined #baserock | 05:32 | |
| *** ctbruce has joined #baserock | 07:31 | |
| *** ctbruce has quit IRC | 07:32 | |
| *** ctbruce has joined #baserock | 07:32 | |
| *** fay has joined #baserock | 07:34 | |
| *** fay is now known as Guest38123 | 07:35 | |
| *** Guest38123 is now known as faybrocklebank | 07:35 | |
| *** paulwaters_ has joined #baserock | 07:37 | |
| *** paulwaters_ has joined #baserock | 07:40 | |
| *** paulwaters_ has joined #baserock | 07:41 | |
| *** paulwaters_ has joined #baserock | 07:51 | |
| *** paulwaters_ has joined #baserock | 07:53 | |
| *** toscalix has joined #baserock | 07:55 | |
| *** paulwaters_ has joined #baserock | 07:58 | |
| *** CTtpollard has joined #baserock | 08:13 | |
| *** ctbruce has quit IRC | 08:32 | |
| *** ctbruce has joined #baserock | 08:32 | |
| *** anahuelamo has joined #baserock | 08:32 | |
| *** ctbruce has quit IRC | 08:48 | |
| *** ctbruce has joined #baserock | 08:49 | |
| *** rdale has joined #baserock | 08:50 | |
| *** franred_ has quit IRC | 09:00 | |
| *** franred has joined #baserock | 09:04 | |
| *** ctbruce has joined #baserock | 09:12 | |
| *** ctbruce has quit IRC | 09:54 | |
| *** ctbruce has joined #baserock | 09:54 | |
| *** andrewleeming__ is now known as leeming | 09:56 | |
| *** locallycompact has joined #baserock | 10:28 | |
| *** gtristan has quit IRC | 10:51 | |
| *** paulwaters_ has joined #baserock | 11:01 | |
| pedroalvarez_ | Updated Changes: | 11:14 |
|---|---|---|
| pedroalvarez_ | https://gerrit.baserock.org/2304 Upgrade to OpenSSL 1.0.2j | 11:14 |
| *** gtristan has joined #baserock | 11:26 | |
| *** gtristan has quit IRC | 11:26 | |
| *** gtristan has joined #baserock | 11:26 | |
| *** pedroalvarez_ is now known as pedroalvarez | 11:46 | |
| *** ctbruce has quit IRC | 11:51 | |
| *** gtristan has quit IRC | 12:47 | |
| *** tiagogomes_ is now known as tiagogomes | 13:17 | |
| *** ctbruce has joined #baserock | 13:39 | |
| cphang | pedroalvarez: Hi! encountered an issue with the baserock-import function which wasn't working as it was using deprecated functions clone_into and unset_defaults (on MorphologyLoader). Restoring clone_into functions and removing the unset_defaults line gave a successful import of the test sinatra gem. | 14:16 |
| pedroalvarez | cphang: aha, do you need any further help? | 14:16 |
| pedroalvarez | are you going to send patches to fix that? | 14:16 |
| cphang | Got patches ready to go, shall I go ahead to put it on gerrit? | 14:17 |
| pedroalvarez | please | 14:17 |
| cphang | The only issue was whether this was a failure in my modified code, or if there's a problem with the check functio? http://paste.baserock.org/cidetirawa | 14:20 |
| pedroalvarez | that error means that the line "/src/morph/morphlib/gitdir.py 488" is not being tested | 14:23 |
| cphang | Ahh okay l488 is the clone_into func from git.py, is that because the test for that's been removed? | 14:32 |
| *** toscalix_ has joined #baserock | 14:32 | |
| pedroalvarez | cphang: hm... not sure, I believe your changes introduced the failure in the tests (given that they work for me in master) | 14:33 |
| pedroalvarez | but without seeing the changes, i can't tell :/ | 14:33 |
| *** toscalix has quit IRC | 14:33 | |
| *** toscalix has joined #baserock | 14:49 | |
| *** toscalix_ has quit IRC | 14:54 | |
| cphang | Apologies I'm having problems getting my branch pushed | 14:56 |
| cphang | Made a new branch from a clone with the commit-msg hook | 14:56 |
| cphang | Set the remote url to ssh://<username>@gerrit.baserock.org:29418/baserock/baserock/morph.git' | 14:57 |
| pedroalvarez | you could try doing `git review -R` | 14:58 |
| pedroalvarez | I don't think you can push a branch there, just send patches to review | 14:58 |
| pedroalvarez | if you want to publish the branch somewhere you need to create your own fork | 15:00 |
| locallycompact | defslib calculating cache keys for assemblages, I think https://gitlab.com/baserock/defslib/blob/master/defslib/__init__.py | 15:11 |
| rjek | shiny | 15:12 |
| cphang | pedroalvarez: Many apologies. Changes should be there | 15:12 |
| cphang | https://gerrit.baserock.org/#/c/2305/ | 15:13 |
| *** gtristan has joined #baserock | 15:20 | |
| pedroalvarez | cphang: right, it looks like we were not covering that function before | 15:38 |
| pedroalvarez | so I suggest you to do the same | 15:38 |
| pedroalvarez | add "# pragma: no cover" next to "clone_into" declaration in gitdir | 15:38 |
| pedroalvarez | also, please remove that ".coverage" file | 15:39 |
| pedroalvarez | And the commit message needs a bit of improving | 15:39 |
| *** ctbruce has quit IRC | 15:41 | |
| cphang | Okay will do, should I submit another patch, or can I do it within the current change-id? | 15:42 |
| pedroalvarez | cphang: within the current change-id please, history of the change will be kept | 15:45 |
| pedroalvarez | I probably should have reviewed it in gerrit, but failed to do so :) | 15:46 |
| cphang | pedroalvarez: okay, thanks :) | 15:46 |
| pedroalvarez | thanks for sending the patch :) | 15:47 |
| locallycompact | paulsher1ood, what is assembly.claim doing? | 16:00 |
| *** anahuelamo_ has joined #baserock | 16:02 | |
| *** anahuelamo has quit IRC | 16:02 | |
| cphang | pedroalvarez: I've updated the patch. I also need to push a patch to import to remove a deprecated unset command too. | 16:32 |
| pedroalvarez | cphang: I've simplified the commit message | 16:36 |
| pedroalvarez | You probably should have a read about good practices in commit messages. First line should be short (less than 80 chars -ish) , and have an empty line after that. | 16:38 |
| cphang | Yeah you're right. Appreciate the heads-up :) | 16:39 |
| pedroalvarez | no worries :) | 16:40 |
| pedroalvarez | commit looks good, I'd like to see the changes to the import tool before merging this one | 16:41 |
| cphang | pedroalvarez: Of course, https://gerrit.baserock.org/#/c/2306/ | 16:48 |
| *** faybrocklebank has quit IRC | 16:53 | |
| *** locallycompact has quit IRC | 17:28 | |
| *** tiagogomes has quit IRC | 17:42 | |
| *** toscalix has quit IRC | 18:23 | |
| *** gtristan has quit IRC | 18:38 | |
| *** rdale has quit IRC | 18:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!