| *** zoli__ has joined #baserock | 03:49 | |
| *** zoli___ has joined #baserock | 04:15 | |
| *** zoli__ has quit IRC | 04:18 | |
| *** petefoth has quit IRC | 05:03 | |
| *** zoli___ has quit IRC | 06:14 | |
| *** petefoth has joined #baserock | 06:23 | |
| *** straycat has joined #baserock | 06:38 | |
| *** petefoth_ has joined #baserock | 06:45 | |
| *** petefoth has quit IRC | 06:47 | |
| *** petefoth_ is now known as petefoth | 06:47 | |
| *** zoli__ has joined #baserock | 07:02 | |
| *** gary_perkins has joined #baserock | 07:23 | |
| *** gary_perkins has quit IRC | 07:25 | |
| *** rdale has joined #baserock | 07:26 | |
| *** gary_perkins has joined #baserock | 07:26 | |
| *** mariaderidder has joined #baserock | 07:42 | |
| *** ssam2 has joined #baserock | 08:06 | |
| *** ChanServ sets mode: +v ssam2 | 08:06 | |
| *** mdunford has joined #baserock | 08:08 | |
| *** gary_perkins has quit IRC | 08:11 | |
| *** tiagogomes has joined #baserock | 08:12 | |
| *** jonathanmaw has joined #baserock | 08:31 | |
| *** gary_perkins has joined #baserock | 08:51 | |
| *** lachlanmackenzie has joined #baserock | 09:22 | |
| * SotK wonders why the x86_32 build system for 15.19 on http://wiki.baserock.org/download/ seems to have "devel-system-64b" as its hostname when booted :) | 09:23 | |
| franred | yep :) | 09:24 |
|---|---|---|
| franred | SotK, are you going to look at the x86_32 bit error? | 09:25 |
| SotK | franred: yeah :) | 09:25 |
| *** nowster has joined #baserock | 09:27 | |
| franred | SotK, I was about to test if with --disable-sse would compile | 09:27 |
| SotK | franred: well I've not even got to the point of being ready to try a build, so maybe it will be better for you to test if you have the time :) | 09:29 |
| franred | SotK, ok, I'll give it a go | 09:30 |
| * franred wonders why we try to build a 64bits system as OpenStack is in 32 bits - why does mason32 build the ci.morph cluster where systems with 32 and 64 bits are described? | 09:42 | |
| SotK | franred: what do you mean? | 09:42 |
| radiofree | i thought the 32bit mason was an entirely different vm? | 09:43 |
| franred | radiofree, it is a different VM but some of the systems which mason32 is trying to build are defined as 64 bits | 09:44 |
| franred | SotK, ^^ | 09:44 |
| radiofree | ah | 09:44 |
| SotK | that's really weird... what's it trying to build thats 64 bit? | 09:44 |
| Zara | (+1000 to changes 577-579 in principle! I'm avoiding reviewing formally since I don't know morph well enough to know what might get broken.) | 09:44 |
| franred | https://mason-x86-32.baserock.org/log/dcf9ad00bcefc4000a319e689303d6046ae71fee--2015-06-15%2008:18:20.log <-- build_cluster morphology ci.morph | 09:44 |
| radiofree | franred: well the 64-bit one uses the same cluster, and is smart enough to only build the 64-bit systems | 09:45 |
| radiofree | maybe mason skips the ones where the arch doesn't match? | 09:45 |
| franred | umm, my bad | 09:46 |
| radiofree | there's also an arm image in that cluster for example | 09:46 |
| franred | is trying to build swift which is added to systems/devel-system-x86_32-generic.morph | 09:47 |
| franred | and defo mason32 builds it | 09:47 |
| franred | radiofree, SotK, sorry for the noise | 09:47 |
| ssam2 | Zara: can you test them and see if they work as described? If so, that's useful info and it makes sense to give a +1 | 09:51 |
| ssam2 | Zara: I sometimes regret that we call this process 'review', since that seems to imply that only line-by-line inspection of the code is useful | 09:52 |
| Zara | ssam2: okay, will try them out! :) | 09:52 |
| ssam2 | I've seen cases where a patch got inspected, merged, and then it turned out to be broken in some way because nobody actually tested it ;) | 09:53 |
| ssam2 | (i'm pretty sure it was my fault in some of those cases, too) | 09:53 |
| *** mdunford has quit IRC | 10:04 | |
| mwilliams_ct | I have a patch (850) with two +1s. is it possible for a +2er to merge or is it still under testing? | 10:09 |
| *** zoli__ has quit IRC | 10:13 | |
| richard_maw | mwilliams_ct: theoretically. If something's had two +1s I have a quick glance in case there's something I see that they've missed, +2 then merge. | 10:17 |
| SotK | Does anyone know what could cause this? http://paste.baserock.org/wufiripeko | 10:17 |
| SotK | (on a jetson) | 10:18 |
| *** mdunford has joined #baserock | 10:18 | |
| mwilliams_ct | richard_maw: well in that case if any +2ers have some time, a quick glance would be appreciated but there's no rush :) | 10:19 |
| richard_maw | SotK: That's a new one. | 10:19 |
| richard_maw | mwilliams_ct: after I've sent a mail to paulsherwood about schemas I'll take a look. | 10:20 |
| mwilliams_ct | thanks richard_maw | 10:20 |
| richard_maw | I had a quick glance earlier, and I'm not sure about your use of IFS, so I'll have to look that up. | 10:20 |
| mwilliams_ct | I'm not sure about it either so any opinions off a shell magi are appreciated | 10:21 |
| richard_maw | tbh I'd shell out to python instead of attempting to parse it in shell | 10:22 |
| *** zoli__ has joined #baserock | 10:35 | |
| richard_maw | mwilliams_ct: I'm 99% sure that IFS doesn't do what I think you intend it to do. | 10:35 |
| mwilliams_ct | 1%? good enough for jazz... | 10:37 |
| mwilliams_ct | richard_maw: it's based roughly on http://stackoverflow.com/a/25678945 | 10:38 |
| kejiahu_ | paulsherwood: openwrt built on armv7 by YBD, and it seems to be functional. But as YBD doesn't do artifact splitting, the resulting image is 10 times larger compare with the morph build | 10:39 |
| richard_maw | mwilliams_ct: I'm not sure where you got the idea that IFS contains a regular expression. | 10:39 |
| mwilliams_ct | richard_maw: trial and error approach. if it's wrong, I'd much rather fix it ofc. would it be better to comment on the patch so folks playing along at home can join in? | 10:41 |
| richard_maw | mwilliams_ct: I'm in the process of doing so | 10:42 |
| *** paulw has quit IRC | 10:42 | |
| mwilliams_ct | cheers :) | 10:42 |
| *** paulw has joined #baserock | 10:43 | |
| franred | SotK, https://gerrit.baserock.org/#/c/863/ <-- patch for 32 bit mason - I've compiled Openstack 64 bits with it and it compiles fine | 10:44 |
| SotK | franred: brilliant, thanks | 10:45 |
| mwilliams_ct | richard_maw: thanks for taking the time to look through, will fixup. I've added your point about shell variable names to the policies page on w.b.o, though perhaps it isn't appropriate there. might be worth creating a coding standards page at some point | 10:57 |
| richard_maw | possibly, we haven't really defined a style guide, and generally rely on following the conventions of the rest of the script | 10:58 |
| richard_maw | we've generally avoided a style guide for shell as we couldn't find anything to crib off, as the google one is for bash and advocates bashisms where we wouldn't be able to use them | 10:59 |
| * ssam2 would prefer our policy on shell code to be: 'Please use a language that is optimised for readability, instead of one that is optimised for being convenient to type' | 11:02 | |
| mwilliams_ct | ssam2: I am in no position to discuss that, having not worked on Baserock that long. please feel free to amend, modify or destroy my wiki edit, just trying to be useful :) | 11:04 |
| nowster | Are there any jbd resources (eg. wiki pages) out there? | 11:13 |
| SotK | nowster: s/jbd/ybd/ ? | 11:15 |
| nowster | yes | 11:15 |
| nowster | sorry | 11:15 |
| SotK | not that I am aware of | 11:15 |
| SotK | I think the only documentation is in readme.md in its git repo | 11:16 |
| nowster | ok... and that's on git.basrock.org? | 11:17 |
| nowster | s/basrock/baserock/ | 11:18 |
| SotK | nowster: https://github.com/devcurmudgeon/ybd | 11:18 |
| nowster | ah, right. | 11:18 |
| petefoth | And it's nothing to do with http://www.ybdclub.com/about.html | 11:20 |
| * SotK is reminded of http://www.djbaserock.com/ | 11:21 | |
| *** zoli___ has joined #baserock | 11:48 | |
| *** zoli__ has quit IRC | 11:51 | |
| richard_maw | ssam2: certainly, the first entry for the style guide should be "If you have an alternative, consider using it." | 11:54 |
| jmacs | I have patch to a system which I don't think will ever be upstreamed; is it acceptable to carry an 11-line patch around in definitions? | 12:35 |
| richard_maw | jmacs: better than many alternatives. Generally we prefer to create a branch with the patch applied, but having the patch in-line in the chunk definition is manageable if it's as short as that | 12:44 |
| jmacs | OK, thanks. | 12:44 |
| straycat | richard_maw, are you likely to look at https://gerrit.baserock.org/#/q/status:open+project:baserock/baserock/morph+branch:master+topic:sam/workspaces-optional-3 anytime soon, it's got 2 +1s and i'd like to a merge it! | 13:06 |
| franred | SotK, radiofree, https://gerrit.baserock.org/#/c/863/2 <-- new version | 13:06 |
| SotK | franred: thanks! | 13:06 |
| richard_maw | straycat: I'll try to find some time today to look over it. | 13:08 |
| straycat | richard_maw, ack, will hold off merge in that case | 13:08 |
| *** edcragg has joined #baserock | 13:17 | |
| richard_maw | straycat: I didn't find anything I didn't like on my first pass. I'm just going through to see if there's any code-level improvements I can think of. Design wise it looks fine, though I'm not sure about the hinted suggestion that we should make the source resolver read files directly out of the git checkout, but that's a different issue. | 13:36 |
| ssam2 | if it works and there's nothing hugely wrong, it seems better | 13:38 |
| ssam2 | + to merge it, then do improvements iteratively | 13:38 |
| richard_maw | fine by me, you can look up my comments after merging if you want | 13:39 |
| franred | https://gerrit.baserock.org/#/c/863/ <-- Im going to merge this if no one has any complaint about it in the next hour (this fixes mason 32 bits) | 13:44 |
| ssam2 | I was about to modify ybd to not put elapsed_time in the build log, then noticed Paul already did it last Thursday :) | 13:47 |
| ssam2 | in the artifact metadata rather | 13:47 |
| paulsherwood | ssam2: actually, i did it saturday, but time stands still on my vm :) | 13:53 |
| ssam2 | that explains why I didn't spot it on friday | 14:01 |
| ssam2 | thanks, anyway | 14:01 |
| richard_maw | ssam2: I have reviewed https://gerrit.baserock.org/#/c/577/3, you may want to address my review of DefinitionsRepo.relative_path | 14:03 |
| ssam2 | thanks, will hopefully get a chance to look at it this week | 14:04 |
| richard_maw | everything else looks fine to me | 14:13 |
| richard_maw | straycat: I've finished reviewing if you want to merge it now. I've not +2d as I'm mostly relying on the judgement of other reviewers, but I wouldn't object to being the one to +2 it if you can't or don't want to. | 14:15 |
| straycat | okay, though i wonder if it's worth fixing path_is_outside_repo before merging? | 14:20 |
| richard_maw | I say that's up to ssam2. The cwd thing won't bite anyone for a while as we'd need someone to try and use it in a new way | 14:22 |
| straycat | oh, heh, i just noticed something :/ | 14:26 |
| richard_maw | oh, actually I missed something important in the call to path_is_outside_repo | 14:27 |
| richard_maw | it's after a relpath call, so it's already normalised | 14:27 |
| *** fay_ has quit IRC | 14:36 | |
| franred | https://gerrit.baserock.org/#/c/863/ --> merged | 14:38 |
| ssam2 | richard_maw: good point about path_is_outside_repo(), I guess it needs a comment to make that clear | 14:42 |
| straycat | ssam2, i've fixed the issues i just commented on, just running tests | 14:43 |
| ssam2 | oh, thanks! | 14:44 |
| *** fay_ has joined #baserock | 15:05 | |
| jmacs | I'm a bit stuck with this patch issue: I've made this extra command in configure-commands: http://paste.baserock.org/eyuwovuqev | 15:14 |
| jmacs | And I've realised my mistake immediately. Thanks. | 15:14 |
| Zara | :D | 15:14 |
| richard_maw | escaped EOF? | 15:14 |
| jmacs | richard_maw: s/path/patch/ | 15:15 |
| richard_maw | probably a good idea to use <<'EOF' too, so your shell doesn't try to evaluate $(mkinstalldirs) when making the patch file | 15:17 |
| jmacs | Good plan. | 15:17 |
| richard_maw | oh, for the interested parties, it's just been announced that systemd intends to relese 221 this week | 15:25 |
| richard_maw | s/relese/release/ | 15:25 |
| * jmacs sighs, no 'patch' in pre-gcc world either | 15:26 | |
| richard_maw | hrm, perhaps we should re-enable busybox's patch implementation | 15:30 |
| richard_maw | it doesn't do fuzzy diffs like the GNU version, but if we've got exact patches to apply this it's better than nothing | 15:30 |
| jmacs | Or I could just keep the patched version in another branch | 15:33 |
| * SotK notices both Masons are failing | 15:33 | |
| jmacs | It's just that that approach isn't so easy when you don't have push access to git.baserock.org | 15:34 |
| SotK | https://mason-x86-32.baserock.org/log/284aec89f5de6f111702065bacd72c31e5fd0c9b--2015-06-15%2015:26:19.log seems pretty weird | 15:35 |
| jmacs | We just merged a patch for gf-complete, didn't we? | 15:36 |
| SotK | yeah, and the patch should have worked | 15:37 |
| SotK | the log looks like its morph doing something weird | 15:37 |
| franred | :/ | 15:38 |
| * SotK notes that mason-x86-64 is failing in a totally different way, failing to transfer the build-system artifact | 15:40 | |
| SotK | s/the build-system artifact/some system artifacts/ | 15:41 |
| jmacs | richard_maw: I've tried putting patch back into stage2-busybox. I don't really get why it was removed though; if there's no other patch, what difference does it make? | 15:51 |
| rdale | i don't think we should remove awk either | 15:53 |
| ssam2 | jmacs: would it help if we gave you push access to git.baserock.org? I think you're doing good work around here. | 15:55 |
| jmacs | Right now I'd rather think about how we make this process easier for the general contributor than giving me special privileges | 15:56 |
| jmacs | Thanks for the offer, thogh | 15:56 |
| jmacs | though | 15:56 |
| ssam2 | ok. with regards to 'patch' in Busybox, it was disabled for a reason | 15:57 |
| ssam2 | I think it's because something depends on GNU Patch, and because we have separate /bin and /usr/bin still, if busybox patch is present in /bin, it gets used in preference to GNU patch, and breaks whatever that thing was | 15:58 |
| ssam2 | so, it's a fixable issue, but not trivially | 15:58 |
| * straycat isn't sure why general contributors don't set up their own trove | 15:58 | |
| straycat | arguably the resource requirements are a little high | 15:58 |
| jmacs | straycat: On what? | 15:59 |
| straycat | but other than that having your own trove can be quite liberating | 15:59 |
| ssam2 | http://git.baserock.org/cgi-bin/cgit.cgi/delta/busybox.git/commit/?h=baserock/build-essential&id=86ae541864b416d6422a58a757e429c6fd88eb0c | 15:59 |
| ssam2 | is where Busybox patch was disabled | 15:59 |
| radiofree | straycat: how much RAM does a trove require? | 16:00 |
| straycat | depends on the number of lorry-controller minions you have running, but given a default of 4 then I guess you'd need an upper bound of 2GB per minion so that would be 8GB | 16:01 |
| jmacs | ssam2: But there is no GNU patch in the staging chroot which gcc gets built in. Are there things outside build-essential that use stage2-busybox? | 16:01 |
| jmacs | (Definitions says no) | 16:01 |
| jmacs | ssam2: That patch applies to "proper" busybox, and it makes sense there, but it was disabled in stage2-busybox too with a similar comment. | 16:03 |
| jmacs | Either way, my copy of gcc seems to have built successfully with busybox's patch. | 16:05 |
| ssam2 | jmacs: the stage2-busybox config is just a clone of the busybox config, I think | 16:09 |
| ssam2 | so I think you could reasonably enable patch in stage2-busybox | 16:09 |
| paulsherwood | jmacs: don't suppose you'd be interested to try toybox instead, while you're there? :) | 16:10 |
| richard_maw | paulsherwood: let's not creep the scope | 16:11 |
| paulsherwood | :) | 16:12 |
| jmacs | paulsherwood: I'm happy to give it a go, but it does take about an hour to do builds since everything depends on busybox | 16:13 |
| paulsherwood | jmacs: understood. cloud vms are the way to go :-) | 16:16 |
| jmacs | Sure. As I said to ripsum though, bear in mind some contributors might not be sponsored. My personal cloud VM would be much slower at building baserock. | 16:18 |
| paulsherwood | jmacs: i think baserock upstream may be able to offer you some time on vms? x86 or arm? | 16:24 |
| jmacs | x86 would be my preference for now | 16:25 |
| *** nowster has quit IRC | 16:25 | |
| *** jonathanmaw has quit IRC | 16:30 | |
| *** franred has quit IRC | 16:32 | |
| *** nowster has joined #baserock | 16:36 | |
| *** gary_perkins has quit IRC | 16:37 | |
| *** mariaderidder has quit IRC | 16:39 | |
| paulsherwood | pedroalvarez, ssam2 ^^ ? | 16:47 |
| Kinnison | I think pedroalvarez is on holiday | 16:47 |
| ssam2 | we have a devel system at Datacentred which you could have access to | 16:56 |
| ssam2 | it's not amazingly well isolated from other systems there, but i trust you not to vandalise anything :) | 16:56 |
| ssam2 | Adam will be using it to do a release tomorrow though, so it may not be much faster | 16:57 |
| ssam2 | we could also instantiate a fresh VM for you if our sponsors agree that it's worth the extra cost :) | 16:57 |
| paulsherwood | ssam2: i think i'm able to speak for a sponsor? +1 from me | 16:59 |
| paulsherwood | git.baserock.org[0: 185.43.218.183]: errno=Connection refused | 17:02 |
| *** bashrc has quit IRC | 17:03 | |
| ssam2 | in what context? git.baserock.org seems fine from here | 17:04 |
| nowster | ssam2: sandboxlib doesn't seem to want to install cleanly | 17:05 |
| paulsherwood | may be me, i guess | 17:05 |
| ssam2 | nowster: how so? | 17:05 |
| nowster | I get an /usr/lib/python2.7/site-packages/UNKNOWN-0.0.0-py2.7.egg | 17:05 |
| ssam2 | using './setup.py install' ? | 17:05 |
| ssam2 | do you have 'pbr' installed? | 17:05 |
| nowster | yes, and I think so | 17:05 |
| ssam2 | jmacs: if you email your public key to admin@baserock.org then I will set up an x86_64 devel system for you in the cloud, then | 17:06 |
| ssam2 | may have to wait til tomorrow though | 17:06 |
| nowster | site-packages/pbr-1.0-py2.7.egg-info/ exists, as does the site-packages/pbr/ dir | 17:06 |
| ssam2 | right. I don't know then | 17:06 |
| nowster | however, /usr/lib/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution option: 'pbr' | 17:07 |
| ssam2 | that sounds suspicious | 17:07 |
| jmacs | ssam2: OK, that sounds great. Thanks! | 17:08 |
| nowster | "import pbr" works in python. | 17:08 |
| ssam2 | I get 'usr/lib/python2.7/site-packages/sandboxlib-0.3.0.post6-py2.7.egg-info' from 'python ./setup.py install' with commit 776019ae8df349cb35fdeb2c37e2e8561bcad31b of git://github.com/codethinklabs/sandboxlib.git | 17:09 |
| nowster | same commit here | 17:09 |
| nowster | pbr is 1.0 | 17:20 |
| nowster | setuptools is 7.0dev | 17:20 |
| nowster | weird | 17:20 |
| *** mdunford has quit IRC | 17:30 | |
| *** ssam2 has quit IRC | 17:52 | |
| nowster | ok... pbr seems to want to hook into setuptools before it calls distutils.setup() | 18:14 |
| nowster | and somehow the hooks aren't getting run | 18:15 |
| paulsherwood | this is just proof of the difficulty of installing 'packages' i guess :/ | 18:20 |
| paulsherwood | nowster: what's your actual error? | 18:21 |
| paulsherwood | jjardon: do you now much about gnome-builder? | 18:48 |
| *** lachlanmackenzie has quit IRC | 18:58 | |
| *** zoli___ has quit IRC | 19:31 | |
| *** zoli__ has joined #baserock | 19:34 | |
| *** zoli__ has quit IRC | 19:59 | |
| *** edcragg has quit IRC | 23:34 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!